chakra-core / ChakraCore

ChakraCore is an open source Javascript engine with a C API.
MIT License
9.11k stars 1.2k forks source link

Provide direct CMake support for clang sanitizer #6924

Closed ppenzin closed 5 months ago

ppenzin commented 1 year ago

Set up a cached CMake variable to enable Clang sanitizer.

rhuanjl commented 5 months ago

Sorry I somehow missed this completely, is it still something you want to progress?

ppenzin commented 5 months ago

Yes, this just moves the sanitizer CMake variable to a level where it can be set independent of build.sh

rhuanjl commented 5 months ago

Yes, this just moves the sanitizer CMake variable to a level where it can be set independent of build.sh

Updated to latest to re-run tests, I'll squash and merge later if the tests pass.