search

chakra-core / ChakraCore

ChakraCore is an open source Javascript engine with a C API.
MIT License
9.06k stars 1.19k forks source link

Attempt fix and enable for Ubuntu 22 #6975

Closed rhuanjl closed 2 months ago

rhuanjl commented 2 months ago

Change from #6932 + enable CI for Ubuntu 22

ppenzin commented 2 months ago

I've played around with this, not sure if there is just one place where the alignment is needed, but hopefully we can figure this out.

ShortDevelopment commented 2 months ago

https://github.com/chakra-core/ChakraCore/issues/6847#issuecomment-2060084507

ppenzin commented 2 months ago

@rhuanjl I've added @ShortDevelopment's fix to the PR, but since it is your branch, feel free to remove/rework/change in anyway you want.

ppenzin commented 2 months ago

And I had to remove that fix, the issue is that MSVC doesn't like noinline attribute, so it has to be an ifdef or something like that - we can revisit. The code would work on Ubuntu and not necessary on Windows.

ppenzin commented 2 months ago

I've updated the workaround to hopefully work on MSVC, trying it out in #6977, though not sure it is the optimal solution in the long run.

rhuanjl commented 2 months ago

Planning to merge #6932 then we can follow up with a working version of this.