chakra-core / ChakraCore

ChakraCore is an open source Javascript engine with a C API.
MIT License
9.1k stars 1.19k forks source link

Upload `bin` directory to azure artifacts #6976

Closed ShortDevelopment closed 5 months ago

ShortDevelopment commented 5 months ago

Goals

Issues


Docs: Azure Pipeline Artifacts

ShortDevelopment commented 5 months ago

@ppenzin Could you have a quick look at this?

rhuanjl commented 5 months ago

@ppenzin what do you think of this temporarily storing our CI builds?

It's not clear how long they kept for.

ShortDevelopment commented 5 months ago

@rhuanjl This can be configured in the Azure DevOps settings https://learn.microsoft.com/en-us/azure/devops/pipelines/policies/retention

ShortDevelopment commented 5 months ago

@JoseIvanHernandez Please stop the spam! I've already reported you to GitHub!

JoseIvanHernandez commented 5 months ago

Apologies. I'm new and didn't realize it was spamming you. Certainly was not my intention. You're the first to reach out, I am very sorry.

rhuanjl commented 5 months ago

Apologies. I'm new and didn't realize it was spamming you. Certainly was not my intention. You're the first to reach out, I am very sorry.

When you comment on a pull request everyone tagged in it gets a notification.

I'm a little confused what you were trying to do here; a pull request (PR) is a request for the maintainers of a project to merge a contribution of some kind. This project is currently maintained by @ppenzin and I; it's up to us if/when a PR is merged.

This PR is a suggested developer experience feature from @ShortDevelopment, we're waiting until my fellow maintainer @ppenzin has a chance to consider it before deciding if to merge it.

If you have any other questions about this project (chakra core) or how to contribute to it feel free to either open an issue or join our discord server to chat (see the read me on the code page for a discord link).

ShortDevelopment commented 5 months ago

I've done a lot of small commits Just squash-merge the whole thing