search

chakra-core / ChakraCore

ChakraCore is an open source Javascript engine with a C API.
MIT License
9.06k stars 1.19k forks source link

Try this==null fix #6977

Closed ppenzin closed 2 months ago

ppenzin commented 2 months ago

Adding contents of #6975 as well as it sets up the pipeline that would expose the miscompilation issue.

ppenzin commented 2 months ago

This is just supplemental to #6975

rhuanjl commented 2 months ago

I think we should give @EmployedRussian a chance to have his version of the first bug merged before we merge our adopted versions - but.... So good to have finally got to the bottom of the Ubuntu 22 issues. Thank you for the time you've put into this.

rhuanjl commented 2 months ago

Do you want to replace my 3 old commits above with the below 2 and then merge this so we have Ubuntu 22 working for now, or would you rather we do a better fix straight off?

https://github.com/chakra-core/ChakraCore/commit/4bae197849d8f597c3781ffec25d18aaf931ef29 and https://github.com/chakra-core/ChakraCore/commit/61c011a568d1659cae158ed4ab57a7f4a67ce0a7

ppenzin commented 2 months ago

I think we should unblock Ubuntu 22, though I will probably try to refactor the code.