chakra-core / ChakraCore

ChakraCore is an open source Javascript engine with a C API.

MIT License

9.06k stars 1.19k forks source link

Fix issue#6982 -- PM128A should be a pointer to 16-byte aligned M128U, not a 16-byte aligned pointer. #6983

Closed EmployedRussian closed 2 months ago

ppenzin commented 2 months ago

6982 (for convenience)

rhuanjl commented 2 months ago

Looks good to me. Upstream (dotnet) PAL got rid of the extra layer of pointers by moving alignment to struct declaration above the line, though that requires some extra changes in other places.

@rhuanjl what do you think?

Long term I'd like to get rid of more PAL if we can but this seems fine to me for now; I went ahead and merged it - can always revisit if we see further problems.