chakra-ui / ark

A headless library for building reusable, scalable design systems that works for a wide range of JS frameworks.
https://ark-ui.com
MIT License
3.52k stars 99 forks source link

signature-pad package dependency missing from ark's solid package.json #2564

Closed ownw closed 2 months ago

ownw commented 2 months ago

Description

Hi, I'm using yarn with pnp (strict option), if a transitive dependency is not specified in a package.json I get an error (build fails).

solid's package.json is missing the @zag-js/signature-pad dependency

[ERROR] [vite] x Build failed in 7.43s
[vite]: Rollup failed to resolve import "@zag-js/signature-pad" from "/home/user/code/project/.yarn/__virtual__/@ark-ui-solid-virtual-54296489ec/0/cache/@ark-ui-solid-npm-3.3.0-3c88a6e1ec-335446c5e6.zip/node_modules/@ark-ui/solid/dist/source/components/signature-pad/use-signature-pad.js".
This is most likely unintended because it can break your application at runtime.

Link to Reproduction (or Detailed Explanation)

¯_(ツ)_/¯

Steps to Reproduce

just use ark ui as usual I would think pnpm also doesn't auto resolve missing transitive dependencies, but for yarn:

#install yarn
yarn set version berry
#in .yarnrc.yml
nodeLinker: pnp
pnpFallbackMode: dependencies-only
pnpMode: strict
yarn add solid-js @ark-ui/anatomy @ark-ui/solid
#build your project

Ark UI Version

3.3.0

Framework

Browser

No response

Additional Information

No response

segunadebayo commented 2 months ago

Good catch @ownw.

Pushed a fix for this. We'll release an update shortly.