chaldea-center / chaldea

Chaldea - Yet Another Material Planner and Battle Simulator for Fate/Grand Order aka FGO

https://docs.chaldea.center

GNU Affero General Public License v3.0

347 stars 26 forks source link

Refactor traits check & remove withXXX pattern #121

Closed SharpnelXu closed 2 months ago

SharpnelXu commented 3 months ago

Changes

Removed withActivator, withTarget, withCard, and withBuff.
Trait checks are now require explicit declaration on what self traits & other traits really are.

SharpnelXu commented 2 months ago

Merged here: https://github.com/chaldea-center/chaldea/commit/c9bef7b6dd424994d20dfb6122abd964b77a3cd4#diff-3b9ea1fd11d4ceb2ec136d3fe3807a3d5e3aee369a990f169ed68b9eaf65c348