search

chaldea-center / chaldea

Chaldea - Yet Another Material Planner and Battle Simulator for Fate/Grand Order aka FGO
https://docs.chaldea.center
GNU Affero General Public License v3.0
322 stars 25 forks source link

[FEATURE] Lack of a Figure/Sprite toggle when reading the story/script. #94

Open beepinboop opened 1 year ago

beepinboop commented 1 year ago

When reading the story, only the background is displayed. Would be nice to also display the servant sprite since in some situations it can be quite difficult to figure out who's talking/being displayed.

The application already has a toggle for the background (when viewing a script > hamburger menu in the top right > Settings > Image), after this implementation I believe it would be better to name one to "Background" and another one to "Figure" (just like on Atlas DB).

I've attached an image, in the top left is how Atlas DB displays Script 0100010010 (https://apps.atlasacademy.io/db/NA/script/0100010010) and in the top right how the Chaldea application displays it. Bottom left is how the application is at the moment and bottom right a very good mock-up of how it would look like.

Thank you for making this app, it's really really useful and browsing all the artworks is very fun.

mockup

narumi147 commented 1 year ago

good sketch The story reader is initially designed to read text only, since the background is not breaking that structure, so added it. but if want to add character figure, I have to rewrite most of code and be lazy to do that >_<.

beepinboop commented 1 year ago

Aww that's a shame, unfortunately I don't code so I can't contribute either. Anyways, thanks for replying and thank you for the App!