chalk / ansi-regex

Regular expression for matching ANSI escape codes
MIT License
184 stars 79 forks source link

Add TypeScript definition #32

Closed Akim95 closed 5 years ago

Akim95 commented 5 years ago

Feel free to contribute and keep it improving!

sindresorhus commented 5 years ago

Thanks for creating a TypeScript definition. 🙌 Can you follow this styleguide?

Some examples:

sindresorhus commented 5 years ago

You need to wrap the options type in a namespace, see https://github.com/sindresorhus/typescript-definition-style-guide#documentation

sindresorhus commented 5 years ago

You still need to do https://github.com/chalk/ansi-regex/pull/32#issuecomment-537818686 and use tab-indentation.

sindresorhus commented 5 years ago

Thanks :)

Akim95 commented 5 years ago

Welcome! :D