chalk / slice-ansi

Slice a string with ANSI escape codes
MIT License
47 stars 21 forks source link

Don't normalize the input string #28

Closed kevva closed 4 years ago

kevva commented 4 years ago

While nifty, and visually it doesn't have an impact. However, when comparing a normalized string to a normal they can differ even though they look the same on the surface. Also, it's not needed for this module to function correctly.

See https://github.com/chalk/slice-ansi/pull/27#issuecomment-533216774 for more details.

Qix- commented 4 years ago

I dont think the test is necessary. It's not required but not not allowed ;)

kevva commented 4 years ago

@Qix-, agree :).

Qix- commented 4 years ago

Thanks! ❤️