chalk / wrap-ansi

Wordwrap a string with ANSI escape codes

MIT License

120 stars 25 forks source link

Support hyperlinks in supported terminals #37

Closed nicholaschiasson closed 4 years ago

nicholaschiasson commented 5 years ago

Fixes #35

IssueHunt Summary

### Referenced issues This pull request has been submitted to: - [#35: Add support for hyperlink](https://issuehunt.io/repos/41053676/issues/35) --- IssueHunt has been backed by the following sponsors. [Become a sponsor](https://issuehunt.io/membership/members)

nicholaschiasson commented 5 years ago

35

sindresorhus commented 5 years ago

// @stroncium @TiagoDanin Would you be able to help review?

sindresorhus commented 4 years ago

@nicholaschiasson Ping :)

nicholaschiasson commented 4 years ago

Just updating, I plan to resolve all of the open discussions here soon! Sorry for the wait 😄

nicholaschiasson commented 4 years ago

Addressed all discussions, but apparently support for node 8 is broken. I will look into this soon.

sindresorhus commented 4 years ago

Support for Node.js 8 doesn’t matter. I plan to target Node.js 10 after this PR.

nicholaschiasson commented 4 years ago

Support for Node.js 8 doesn’t matter. I plan to target Node.js 10 after this PR.

Ah whoops, I fixed it nonetheless. Up to you which style is preferable, named regex capture groups or not, but in any case I think this is ready again for review.

sindresorhus commented 4 years ago

Can you revert https://github.com/chalk/wrap-ansi/pull/37/commits/2b6a0b4050412cc074214650c2ce73e219316b4c?

sindresorhus commented 4 years ago

Thank you :)