challo2018 / LoxBerry-Plugin-Vitoconnect

LoxBerry Plugin to access Viessmann API
Apache License 2.0
3 stars 3 forks source link

Introduce aggregatedstatus_ok #3

Closed jo-math closed 1 year ago

jo-math commented 1 year ago

Hi Fabian,

I created the PR in order to introduce aggregatedstatus_ok, which is based on aggregatedstatus. It is 1 if the value of aggregatedstatus is WorksProperly (case insensitive). In other cases, it is 0.

Automatic alerting with this new attribute is easy, as it is just boolean. I did not alter the release information, as this is up to you as maintainer.

Does this PR makes sense to you?

challo2018 commented 1 year ago

Would be easier if you only submit changed vitoconnect.php from 9f58f62 for this request

jo-math commented 1 year ago

True, sorry, my fault. I just wanted to propose the change of the vitoconnect.php and nothing else.