Fixing BPP from 24 to 3 to fix segfault in proxy-camera/memcpy

chrberger commented 8 years ago

The configuration file needs to be adjusted by replacing 24 (assumed bits) with 3 (bytes representing the bytes per pixel):

Adjust detectvehicle by removing /8:

https://github.com/chalmers-revere/opendlv/blob/experiment.idiada/code/system/application/perception/src/detectvehicle/detectvehicle.cpp#L97

Activate mySharedImg.getBytesPerPixel():

https://github.com/chalmers-revere/opendlv/blob/experiment.idiada/code/system/application/perception/src/detectlane/detectlane.cpp#L89

olbender commented 8 years ago

Doesn't 'bpp' really translate to "bits per pixel"?

bjornborg commented 7 years ago

Is this solved?

olbender commented 7 years ago

At least it's very old :) I do not remember the details, but things are working now so perhaps close?

bjornborg commented 7 years ago

As far as I know, it's working but slight confusing if the bpp stands for bytes per pixel or bits per pixel.

olbender commented 7 years ago

It should be "bits per pixel", I think it might be dangerous to mix this up. Bytes per pixel seems to be a quite odd format, we could perhaps write that as "bytesPerPixel" just to be clear. Perhaps we should also have "bpp" in the config, and then divide by 8 in the code.

bjornborg commented 7 years ago

Actually by looking at https://github.com/chalmers-revere/opendlv.core/blob/master/code/core/system/proxy-camera-axis/src/Camera.cpp#L50 , it seems to be bytes per pixel... :) I hope we didn't mix this up hard...

olbender commented 7 years ago

To use "setBytesPerPixel" is fine, but we should not use "BPP" since that could be confusing.

olbender commented 7 years ago

@chrberger Should we do anything with this, or close it?

chalmers-revere / opendlv

Fixing BPP from 24 to 3 to fix segfault in proxy-camera/memcpy #16