search

chamchenko / plugin.video.nbainternational

NBA Add-On for Kodi
GNU General Public License v2.0
8 stars 6 forks source link

Proposed Remodel #5

Closed scottydulton closed 1 year ago

scottydulton commented 3 years ago

Proposed Changes:

chamchenko commented 3 years ago

Hi @scottydulton Thank you for the ideas, I really appreciate it. I don't really agree on some part of the modifications, so I'm not gonna be merging this. But there are many ideas that I'm really going to consider moving forward. But hey I'm really glad that you're able to tweak this and make it more adaptable to your needs, as my goal when I started rewriting the plugin was to make it more customizable and easier to maintain.

scottydulton commented 3 years ago

@chamchenko no probs mate which parts were you not keen on? Also while looking through I noticed when searching 'older' in Archive games if you try to search back further then the 19-20 season you get a 'caData' error, let me know if you want me to raise an issue with logs etc but it seems like it is trying to use xbmc rather then xbmcvfs

chamchenko commented 3 years ago

Hi @scottydulton, The archive games issue should be fixed in the last commit.