search

chamilo / chamilo-lms

Chamilo is a learning management system focused on ease of use and accessibility
https://chamilo.org
GNU General Public License v3.0
812 stars 485 forks source link

How to hide IP-address? #2526

Open Elearner2018 opened 6 years ago

Elearner2018 commented 6 years ago

Current behavior / Resultado actual / Résultat actuel

When the teacher is checking the learners' exercises, he can see the IP-address of the learner.

Expected behavior / Resultado esperado / Résultat attendu

How to hide the shown IP-address?

Steps to reproduce / Pasos para reproducir / Étapes pour reproduire

Chamilo Version / Versión de Chamilo / Version de Chamilo

1.11.4

NicoDucou commented 6 years ago

There is no option to hide the IP address for the moment, that would be a new feature.

jderriks commented 6 years ago

https://github.com/chamilo/chamilo-lms/blob/000f93c6acc2691a1f8ace7612a07702417713af/main/exercise/exercise_report.php#L625 delete or comment that line I guess...

ywarnier commented 6 years ago

I think that only removes the title. You would have to modify exercise.lib.php::get_exam_results_data() to avoid fetching the user_ip column, too.

ywarnier commented 6 years ago

I did a little test to add that but that would mean putting configuration checks on both sides (exercise_report.php and exercise.lib.php and maybe some intermediates). I feel like we should do that better, for example by implementing something at the Display::grid_js() level to pass a parameter for columns to be hidden.