search

chamilo / chamilo-lms

Chamilo is a learning management system focused on ease of use and accessibility
https://chamilo.org
GNU General Public License v3.0
785 stars 478 forks source link

adding right to left text alignment in text editor #2869

Closed Mo-dot2 closed 5 years ago

Mo-dot2 commented 5 years ago

currently there is only align to left and center options in text editor so I suggest putting align to right to suit languages which right to left like Arabic image

image

ywarnier commented 5 years ago

Just sent a fix for that. Sorry, we didn't realize that was a hindrance to RTL writers. Thanks for reporting it. Whenever needed to keep the size minimal (in the minimal editor bars), I have replaced "Align block" by "Align right". The "Align block" option is still always available in the maximized version of the editor, which I believe is still very natural. I haven't tested all the interfaces, but I have modified all the corresponding files, so maybe some interface got one additional line of icons with just one icon. This can be fixed along the way and in the worst case we could remove the "center align" option, which shouldn't be used in any proper quick text (meaning with the minimal editor) anyway.

Please review, give us your comments and we'll be able to close it.

Mo-dot2 commented 5 years ago

Thanks @ywarnier ♥ that was a quick fix! I tested and it worked fine I would also like to suggest removing the flash icon form mini editor (because it's old technolgy and won't work on mobile devices or tablets) image

I would also like to know the scheduled release date for Chamilo ♥ 1.11.10

Mo-dot2 commented 5 years ago

I think it would be a good idea to include smiley faces in the mini editor this would suit younger learners who are addicted to use them in other social apps (facebook, whatsup, telegram...etc.)

image

ywarnier commented 5 years ago

The Flash icon (and the smiley icon) should be 2 separate issues (because they are not as important as the RTL issue and should be treated separately). I'll let you do that when you have time. Thanks for confirming the fix.