search

chamilo / chamilo-lms

Chamilo is a learning management system focused on ease of use and accessibility
https://chamilo.org
GNU General Public License v3.0
811 stars 483 forks source link

sort on active users not working properly #3517

Open spacecabbie opened 4 years ago

spacecabbie commented 4 years ago

Describe When sorting on active it wil not properly do so see screenshot. image

To Reproduce Steps to reproduce the behavior: I am unable to reproduce on 11.chamilo.org the user list is to big there also i suspect it has to do with custom field being enabled on our installation. We use 2 custom field witch are working afther resolve of bug: https://github.com/chamilo/chamilo-lms/issues/3283 https://github.com/chamilo/chamilo-lms/issues/3488

Expected behavior When Sorting I expect it to go from Active/Deactive/unset status and vica versa.

Desktop (please complete the following information):

**Server

Additional context This is i think due to use of custom fields if it cannot be confirmed straigt away let me know.

AngelFQC commented 4 years ago

Hi @spacecabbie

chamilo/chamilo-lms:/main/admin/user_list.php#L471

The user extrafields don't affect the query that orders the results

https://github.com/chamilo/chamilo-lms/blob/1.11.x/main/admin/user_list.php#L470-L472

spacecabbie commented 4 years ago

Hi @spacecabbie

chamilo/chamilo-lms:/main/admin/user_list.php#L471

The user extrafields don't affect the query that orders the results

https://github.com/chamilo/chamilo-lms/blob/1.11.x/main/admin/user_list.php#L470-L472 I see,

So I went exploring in that file i think i might have found it: https://github.com/chamilo/chamilo-lms/blob/1.11.x/main/admin/user_list.php#L232-L233 Those seem to be reversed: image col8 is column: active and col7 is column: locked. not sure if locked is suposed to be status but seems logical.

Since i am still an absolute novice on php, i''ll post findings here first if you could confirm I would like to create a pull request and make the change myself since it would mean its my very first bug fix ever.

AngelFQC commented 4 years ago

Hi @spacecabbie

The image you show has the columns from the user table. But in the SQL query the col8 refers to the active column. So, the ordering would be done by the active column

spacecabbie commented 4 years ago

Hi @spacecabbie

The image you show has the columns from the user table. But in the SQL query the col8 refers to the active column. So, the ordering would be done by the active column

@AngelFQC Alright I understand The code is quite beyond me i have to admit. Added 2 screenshots to show the difference. when switching the column https://i.imgur.com/5hd7AQ0.png https://i.imgur.com/rTWwIoI.png

Do you have any idea what might be going on ?