Replace "name" with "title" fields in tables

ywarnier commented 3 years ago

Chamilo 2.0 is a great opportunity to clean the mess up a little bit in our database structure. At the moment, there is a mix between fields called "name" and fields called "title", where they all represent the textual name of the item represented by the table row.

Move all "name" fields to "title", to sanitize this.

Making this a standard with help with the capability to predict the field name and, as such, will improve development speed in the long run.

Beware that some of these fields are also indexed. Indexes should be modified too.

Tables with "name":

[x] block.name
[x] branch_sync.branch_name
[x] c_attendance.name
[x] c_blog.blog_name
[x] c_dropbox_category.cat_name
[x] c_exercise_category.name
[x] c_forum_category.cat_title
[x] c_forum_forum.forum_title
[x] c_forum_post.post_title
[x] c_forum_thread.thread_title
[x] c_glossary.name
[x] c_group_info.name
[x] c_link_category.category_title
[x] c_lp.name
[x] c_lp_category.name
[x] c_online_link.name
[x] c_quiz_question_option.name
[x] c_role.role_name
[x] c_survey_group.name
[x] c_tool.name
[x] career.name
[x] chat_video.room_name
[x] class_item.name
[x] course_category.name
[x] course_module.name
[x] course_type.name
[x] grade_model.name
[x] gradebook_category.name
[x] gradebook_evaluation.name
[x] gradebook_linkeval_log.name
[x] mail_template.name
[x] promotion.name
[x] sequence.name
[x] sequence_row_entity.name
[x] sequence_type_entity.name
[x] sequence_variable.name
[x] session.name
[x] session_category.name
[x] skill.name
[x] skill_level.name
[x] skill_level_profile.name
[x] skill_profile.name
[x] specific_field.name
[x] ticket_category.name
[x] ticket_priority.name
[x] ticket_project.name
[x] ticket_status.name
[x] usergroup.name

So that's 48 changes, vs 39 'title' fields (and 38 pure "name" fields).

christianbeeznest commented 1 year ago

Request is done in this PR https://github.com/chamilo/chamilo-lms/pull/4706

NicoDucou commented 1 year ago

I switch to branch GH-3581-2 and update the table schema :

root@testing:/var/www/testing24.beeznest.com/www# php8.1 bin/console doctrine:schema:update --force

 [WARNING] Not passing the "--complete" option to "doctrine:schema:update" is deprecated and will not be supported when 
           using doctrine/dbal 4                                                                                        

 Updating database schema...

     89 queries were executed

 [OK] Database schema updated successfully!

After this I checked the table and column names in the database :

SELECT DISTINCT TABLE_NAME, COLUMN_NAME FROM INFORMATION_SCHEMA.COLUMNS WHERE column_name LIKE '%name%'; It seems all good, @ywarnier I just wonder if those fields should stay with "name" or if it should be changed to "title" in thos tables :

[ ] fos_group
[ ] c_shortcut
[ ] c_wiki_category
[ ] c_chat_conversation
[ ] illustration
[ ] resource_type
[ ] resource_format
[ ] tool (It is strange because in the code there is already references to tool.title instead of tool.name
[ ] skill_level (We have a title field and then a short_name field, I think it should be transformed to short_title)
[ ] track_e_hotpotatoes (we have exe_name but in the c_quiz table it is called "title" now so I think it should be "exe_title")
[ ] resource_tag
[ ] lti_external_tool

Then I did a quick review of code and see that the migrations are present. Appart from the remarks above to define if we should include those extra tables, changes in the PR seems correct and we will see once accepted if there was a missing change that generate error when usgin the funcionality since I can not test all the plateform to validate all functionalities.

So @ywarnier I let you confirm for the tables indicated above and reassign to @christianbeeznest to do those changes and to adapt the PR because there are conflicts now so it can not be merged.

ywarnier commented 9 months ago

Retaking your list here:

[ ] fos_group is OK because we don't know yet what we're going to do with that table (probably remove it)
[x] c_shortcut
[x] c_wiki_category
[x] c_chat_conversation
[x] illustration
[x] resource_type
[x] resource_format
[x] tool (It is strange because in the code there is already references to tool.title instead of tool.name
[x] skill_level (We have a title field and then a short_name field, I think it should be transformed to short_title)
[x] track_e_hotpotatoes (changed "exe_name" to "title" -> the idea is to have a standard, not a smooshy, partial name change)
[x] resource_tag
[x] lti_external_tool

ywarnier commented 9 months ago

Fixed through https://github.com/chamilo/chamilo-lms/commit/faeca062624e4fa0c0eba86e54c25e490c000f49

chamilo / chamilo-lms

Replace "name" with "title" fields in tables #3581