chamilo / chamilo-lms

Chamilo is a learning management system focused on ease of use and accessibility
https://chamilo.org
GNU General Public License v3.0
798 stars 480 forks source link

Error when trying to create a course in Hebrew #4670

Closed guymass closed 1 year ago

guymass commented 1 year ago

When ever I try to create a course with Hebrew title I get an error and it will not be created, however when I try in english I also get the same error but this time the course is created. Here are some screen shots:

although my interface is in Hebrew the field is for the course name and the button is for the create just for clarification:

A new test course in English:

Screen Shot 5783-07-15 at 21 12 22 I get this error page:

Screen Shot 5783-07-15 at 21 12 31 Screen Shot 5783-07-15 at 21 12 53

But on my courses page I see it just fine: Screen Shot 5783-07-15 at 21 13 52

On Hebrew I get the following and the course is not created or shown on my courses list:

Screen Shot 5783-07-15 at 21 13 43

It just says the course was not created. IMHO there is still not complete support with RTL languages and handeling Hebrew or Arabic languages.

I would like to be able to use it more in my language as much as possible so it would be greate if someone more knowledgeable can fix this problem.

much thanks in advance :-)

ywarnier commented 1 year ago

Hi @guymass Let us check this. It's probably some very minor issue of escaping a quote in the JavaScript part of Chamilo (the defaults-he_HE.min.js it talks about). If so, we've already fixed similar issues for French and it's usually directly coming from some language string that has a quote where we're not expecting a quote.

NicoDucou commented 1 year ago

This commit fix the error when creating a course in hebrew. It does not block anymore on the folders creation in the document tool. But there is still a problem when creating a course with a title with special caracters (for exemple with "לי האג'נדה שלי" as the title) then it blocks and does not create the course, nor gives a error message and just gets back to the list of course but with no course creation.

guymass commented 1 year ago

Nice to hear from you, much thanks I will test it now again after update..

On Wed, May 31, 2023 at 10:59 AM Nicolas Ducoulombier < @.***> wrote:

This commit fix the error when creating a course in hebrew. It does not block anymore on the folders creation in the document tool. But there is still a problem when creating a course with a title with special caracters (for exemple with "לי האג'נדה שלי" as the title) then it blocks and does not create the course, nor gives a error message and just gets back to the list of course but with no course creation.

— Reply to this email directly, view it on GitHub https://github.com/chamilo/chamilo-lms/issues/4670#issuecomment-1569684823, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOBHWVYE4UC6UZXHQMXYHV3XI324NANCNFSM6AAAAAAWVXPMJE . You are receiving this because you were mentioned.Message ID: @.***>

ywarnier commented 1 year ago

I'm considering this issue closed, with the negative effect that it doesn't filter special characters. We can work on that last issue in a later version, but hopefully this should not affect too many people.