search

chamilo / chamilo-lms

Chamilo is a learning management system focused on ease of use and accessibility
https://chamilo.org
GNU General Public License v3.0
798 stars 480 forks source link

C2: Add migration for links/tools on homepage from C1 to C2 #5088

Closed ywarnier closed 3 months ago

ywarnier commented 9 months ago

The migration currently does not deal with links (and other resources) that were added on the courses' homepages in C1 (to the c_tool table). These should now be transformed into "shortcuts" in C2.

Linked to #5073

ywarnier commented 7 months ago

I'm changing the assignee for approval here, because @NicoDucou will be going through a comprehensive migration soon. This is just a note that there should be a check that links and other resources (like LPs) marked as "show on course homepage" should now be converted to shortcuts when migrated from 1.11 to 2.0.

NicoDucou commented 6 months ago

The link do not appear for the moment on the homepage. It can be checked after migration on this course : https://.........../course/154/home There should be a LP on the homepage.

AngelFQC commented 6 months ago

Migration is done for learnpaths and learnpath categories. For links, it was already done.

However, on the functionality side of showing the course home, is needed to filter the learnpath and lp category shortcuts to show then according to the prerequisites between learnpaths

AngelFQC commented 6 months ago

However, on the functionality side of showing the course home, is needed to filter the learnpath and lp category shortcuts to show then according to the prerequisites between learnpaths

Related issue #5357

NicoDucou commented 6 months ago

Hola Angel, Estuve revisando este issue para validarla pero no me ha funcionado en la migracion de la semana pasada. Revisando me doy cuenta que no se hizo merge al PR https://github.com/chamilo/chamilo-lms/pull/5310 Entonces por eso no estaba incluido en la migracion que hice. Veo que ahora hay conflictos y no se puede hacer merge. Podrias revisarlo y hacer el merge a menos que tengas una razon por no hacer lo ?

ywarnier commented 6 months ago

@NicoDucou acabo de mandar un commit que arregla el conflicto menor. Estaba revisando los PRs, así que lo hice de paso.

AngelFQC commented 5 months ago

I've rebased with master to re-resolve the conflict and change the calls to container and entity manager (post symfony 6 changes)