search

chamindra / marvim

MARVIM - MAcro Repository for VIM "Give your most complex macros a name and store it for future recall and use"
GNU General Public License v2.0
34 stars 8 forks source link

Fix macro ending with '^M' #10

Closed antoinemadec closed 5 years ago

antoinemadec commented 5 years ago

setreg() help says: "If {options} contains no register settings, then the default is to use character mode unless {value} ends in a "

Make sure to pass 'c' option to use character mode even when the macro ends with '^M'.

Fixes #9

antoinemadec commented 5 years ago

Thanks for the great plugin btw :smiley:

omrisarig13 commented 5 years ago

@antoinemadec - Thank you very much for your bug-report and fix.

You are completely correct, this was a bug in the plugin, and your fix worked. I merged it back to the master.

chamindra commented 5 years ago

Thanks @antoinemadec and Omri!

Chamindra de Silva https://www.linkedin.com/in/chamindra | http://chamindra-de-silva.blogspot.com

https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avast.com https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Sat, Sep 14, 2019 at 8:32 AM Omri Sarig notifications@github.com wrote:

@antoinemadec https://github.com/antoinemadec - Thank you very much for your bug-report and fix.

You are completely correct, this was a bug in the plugin, and your fix worked. I merged it back to the master.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chamindra/marvim/pull/10?email_source=notifications&email_token=ABTG6G7Q4HYCWCVN66H7TXLQJSHRZA5CNFSM4IWUHEB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6WWPTY#issuecomment-531457999, or mute the thread https://github.com/notifications/unsubscribe-auth/ABTG6GY27HYGC36SAB2N5K3QJSHRZANCNFSM4IWUHEBQ .