search

chamindra / marvim

MARVIM - MAcro Repository for VIM "Give your most complex macros a name and store it for future recall and use"
GNU General Public License v2.0
34 stars 8 forks source link

Refactor plugin #3

Closed omrisarig13 closed 5 years ago

omrisarig13 commented 5 years ago

I refactored the whole plugin, to make it more suitable to today plugin's standard in vim.

I didn't change almost any functionality of the plugin, all the functionality I changed was fixing TODO messages in the code and small fixes of bugs I found on the way.

chamindra commented 5 years ago

Hi Omri,

Sorry I could not reply earlier. I had a busier weekend than planned. I have approved the merge request now. How much have you tested it so far?

Chamindra de Silva https://www.linkedin.com/in/chamindra | http://chamindra-de-silva.blogspot.com

On Sat, Jun 15, 2019 at 2:23 PM Omri Sarig notifications@github.com wrote:

I refactored the whole plugin, to make it more suitable to today plugin's standard in vim.

I didn't change almost any functionality of the plugin, all the functionality I changed was fixing TODO messages in the code and small fixes of bugs I found on the way.

You can view, comment on, or merge this pull request online at:

https://github.com/chamindra/marvim/pull/3 Commit Summary

  • Refactored the plugin code.
  • Update readme.md file
  • Added doc directory.
  • Typo fixes and redundant docs removed.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chamindra/marvim/pull/3?email_source=notifications&email_token=ABTG6G443XHN4KX3ZQ63VI3P2TUNRA5CNFSM4HYPA7U2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GZWGVHQ, or mute the thread https://github.com/notifications/unsubscribe-auth/ABTG6GZEI4DALFLDNQSUCQ3P2TUNRANCNFSM4HYPA7UQ .

chamindra commented 5 years ago

Thanks Omri,

I am going to publish this as v0.5. Can you provide me with the details for the change log.

Chamindra de Silva https://www.linkedin.com/in/chamindra | http://chamindra-de-silva.blogspot.com

On Tue, Jun 18, 2019 at 3:50 AM Chamindra de Silva chamindra@gmail.com wrote:

Hi Omri,

Sorry I could not reply earlier. I had a busier weekend than planned. I have approved the merge request now. How much have you tested it so far?

Chamindra de Silva https://www.linkedin.com/in/chamindra | http://chamindra-de-silva.blogspot.com

On Sat, Jun 15, 2019 at 2:23 PM Omri Sarig notifications@github.com wrote:

I refactored the whole plugin, to make it more suitable to today plugin's standard in vim.

I didn't change almost any functionality of the plugin, all the functionality I changed was fixing TODO messages in the code and small fixes of bugs I found on the way.

You can view, comment on, or merge this pull request online at:

https://github.com/chamindra/marvim/pull/3 Commit Summary

  • Refactored the plugin code.
  • Update readme.md file
  • Added doc directory.
  • Typo fixes and redundant docs removed.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chamindra/marvim/pull/3?email_source=notifications&email_token=ABTG6G443XHN4KX3ZQ63VI3P2TUNRA5CNFSM4HYPA7U2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GZWGVHQ, or mute the thread https://github.com/notifications/unsubscribe-auth/ABTG6GZEI4DALFLDNQSUCQ3P2TUNRANCNFSM4HYPA7UQ .

omrisarig13 commented 5 years ago

Hey,

It's totally fine that you didn't answer earlier, there is no rush in working on this.

To answer you first question, I have tested the plugin only on my machine, but I tried to test all the features of it. I saved new macros and templates, loaded them, and did it for multiple directories and different file types. It seems to work. My machine as ManjaroLinux 18.0.4 (a distribution based on Arch), with vim 8.1.1467. I could not test the plugin on any other machine, since I have none.

About the change log. The changes I did are documented in the documentation of the plugin (I forgot to add them to the readme as well). The documentation are here - https://github.com/chamindra/marvim /blob/2a28500d5fcec1710849e0536f541f1316bef963/doc/marvim.txt#L144

However, when reading and refactoring the plugin I came across some more features/small bugs that I would want to fix. This is the list with all the things that I wanted to do:

I intended to open all those as issues in the github, and work them one by one in the near future. If you have some input on those issues I would be happy to hear it.

Omri

On Tue, Jun 18, 2019 at 12:53 PM Chamindra de Silva < notifications@github.com> wrote:

Thanks Omri,

I am going to publish this as v0.5. Can you provide me with the details for the change log.

Chamindra de Silva https://www.linkedin.com/in/chamindra | http://chamindra-de-silva.blogspot.com

On Tue, Jun 18, 2019 at 3:50 AM Chamindra de Silva chamindra@gmail.com wrote:

Hi Omri,

Sorry I could not reply earlier. I had a busier weekend than planned. I have approved the merge request now. How much have you tested it so far?

Chamindra de Silva https://www.linkedin.com/in/chamindra | http://chamindra-de-silva.blogspot.com

On Sat, Jun 15, 2019 at 2:23 PM Omri Sarig notifications@github.com wrote:

I refactored the whole plugin, to make it more suitable to today plugin's standard in vim.

I didn't change almost any functionality of the plugin, all the functionality I changed was fixing TODO messages in the code and small fixes of bugs I found on the way.

You can view, comment on, or merge this pull request online at:

https://github.com/chamindra/marvim/pull/3 Commit Summary

  • Refactored the plugin code.
  • Update readme.md file
  • Added doc directory.
  • Typo fixes and redundant docs removed.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/chamindra/marvim/pull/3?email_source=notifications&email_token=ABTG6G443XHN4KX3ZQ63VI3P2TUNRA5CNFSM4HYPA7U2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GZWGVHQ , or mute the thread < https://github.com/notifications/unsubscribe-auth/ABTG6GZEI4DALFLDNQSUCQ3P2TUNRANCNFSM4HYPA7UQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chamindra/marvim/pull/3?email_source=notifications&email_token=AKDEWM22XMTPJICXWIPRUD3P3CWCZA5CNFSM4HYPA7U2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX53FIQ#issuecomment-503034530, or mute the thread https://github.com/notifications/unsubscribe-auth/AKDEWM3XYOU4CKEYV424EYTP3CWCZANCNFSM4HYPA7UQ .