search

chamindra / marvim

MARVIM - MAcro Repository for VIM "Give your most complex macros a name and store it for future recall and use"
GNU General Public License v2.0
34 stars 8 forks source link

Seperate templates and macros API #4

Closed omrisarig13 closed 5 years ago

omrisarig13 commented 5 years ago

Currently, the plugin uses the macros and the templates it saves indifferently, it saves them in the same location, and the same function finds both templates and macros.

It causes small issues, like when there is macro and template file by the same name, the macro would always be used. Moreover, it might cause unwanted results when calling up a macro or a template, and getting the other one, since they are saved in the same location.

This issue would separate the location of the macros and the templates, and add options to call separately for only macros or only templates. This issue would not interfere with the current API of the plugin, but expend it. The original API would be preserved, and it would be possible to continue using it.

omrisarig13 commented 5 years ago

This issue depends on the result of issue #6. When adding this functionality, it would require to add an option to choose between the macros and the template files, so it would be better to fix this issue only after finishing with the previous one, to avoid duplications and errors.

chamindra commented 5 years ago

My original thought process on this was that a template can be classified in a way as a special type of macro. Creating this macro using a template is easier than doing it the usual way by recording a register. A person who did not create the repository is none the wiser

Chamindra

On Sat, 29 Jun 2019 at 2:56 pm, Omri Sarig notifications@github.com wrote:

Currently, the plugin uses the macros and the templates it saves indifferently, it saves them in the same location, and the same function finds both templates and macros.

It causes small issues, like when there is macro and template file by the same name, the macro would always be used. Moreover, it might cause unwanted results when calling up a macro or a template, and getting the other one, since they are saved in the same location.

This issue would separate the location of the macros and the templates, and add options to call separately for only macros or only templates. This issue would not interfere with the current API of the plugin, but expend it. The original API would be preserved, and it would be possible to continue using it.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chamindra/marvim/issues/4?email_source=notifications&email_token=ABTG6G3XF7T6O36XFQGQELDP45SZXA5CNFSM4H4KOMZKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G4OGYKA, or mute the thread https://github.com/notifications/unsubscribe-auth/ABTG6GYYGFOQPFDVUETK3LTP45SZXANCNFSM4H4KOMZA .

-- Chamindra de Silva https://www.linkedin.com/in/chamindra | http://chamindra-de-silva.blogspot.com

omrisarig13 commented 5 years ago

As for now, we have decided that such feature is indeed redundant, and there is no need for it.