chamlamh / EntAppDevelopmentFinalProject

Final project in Ent App Development
0 stars 0 forks source link

Chris doan code review 1 #22

Open chrisdoan0824 opened 3 years ago

chrisdoan0824 commented 3 years ago

Code Review: (10/30/2021)

Analysis of the program: The program, while lacking a bit of functionality, is a good start for further development. The controller, DTO, and DAO is set up properly, and all the get and post request for the endpoints are properly set up makes navigating the app/sites smoothly. The HTML and thymeleaf notations were properly set up, and the project implemented bootstrap for styling. While some aspects of the project could be cleaner, this project should be good to go for further development. Overall, good job!

Was the program available on time: I was added as a collaborator to the project repository as soon as possible, I did not have to wait for aspects of the project.

Is the program documented/commented well enough for you to understand: The project has proper documentation making it easier to understand and the code followed appropriate naming conventions. There was no real issue understanding any aspect of the project's codebase.

Does the program compile: Yes, the project compiled with no errors.

Three specific technical concepts: