search

chamnap / themes_on_rails

Adds multi themes support to your Rails 3/4/5 application
https://rubygems.org/gems/themes_on_rails
MIT License
217 stars 86 forks source link

set theme layout only once #20

Closed bastengao closed 8 years ago

bastengao commented 9 years ago

Set theme layout at #apply_theme only once, but not in before_filter every request.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 93.27% when pulling d7e09fd94d42da6db6b81bacc1505c45cda82240 on bastengao:set-layout-only-once into 3243b758e8250602ee1ae702a135759d3b7a280c on yoolk:master.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 93.27% when pulling d7e09fd94d42da6db6b81bacc1505c45cda82240 on bastengao:set-layout-only-once into 3243b758e8250602ee1ae702a135759d3b7a280c on yoolk:master.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 93.27% when pulling d7e09fd94d42da6db6b81bacc1505c45cda82240 on bastengao:set-layout-only-once into 3243b758e8250602ee1ae702a135759d3b7a280c on yoolk:master.

alwolfe commented 9 years ago

Hi @chamnap, this seems to be attempting to solve the same issue as the only other pull request. Can we get these reviewed and the better solution in your mind merged?

chamnap commented 8 years ago

I've merged on the other PR. Thanks.