search

championswimmer / vuex-persist

A Vuex plugin to persist the store. (Fully Typescript enabled)
http://championswimmer.in/vuex-persist
MIT License
1.67k stars 116 forks source link

Mutation type argument in storage methods #27

Open benitogf opened 6 years ago

benitogf commented 6 years ago

It would be nice to receive the mutation type in setItem, getItem methods, as I see it would be easy to implement passing it to saveState here and it would not interfere with the current behavior, this will give more flexibility on how to deal with different mutations in the storage side, what do you think?

championswimmer commented 6 years ago

Sounds good, we can do this

On 24-Jan-2018 7:27 PM, "benito" notifications@github.com wrote:

It would be nice to receive the mutation type in setItem, getItem methods, as I see it would be easy to implement passing it to saveState here https://github.com/championswimmer/vuex-persist/blob/master/src/index.ts#L206 and it would not interfere with the current behavior, this will give more flexibility on how to deal with different mutations in the storage side, what do you think?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/championswimmer/vuex-persist/issues/27, or mute the thread https://github.com/notifications/unsubscribe-auth/ABQ_yoVfT-DveFrGJdg3f-jQ5BpjJpIsks5tNzbggaJpZM4RrS3S .