search

champsproject / ldds

Python package for computing and visualizing Lagrangian Descriptors in Dynamical Systems
BSD 3-Clause "New" or "Revised" License
17 stars 2 forks source link

Incorrect label tau when plotting discrete systems with draw_all_lds #43

Closed broncio123 closed 3 years ago

broncio123 commented 3 years ago

image

vkrajnak commented 3 years ago

Indeed in a discrete system time, i.e. number of iteration, is usually not denoted as tau. Since draw_all_lds is called the notebook, using the plot handle to add a title from the notebook is not feasible. I can suggest removing it, or much rather leave it as is and address this discrepancy in the documentation. In the end, it's not that bad, is it?

vkrajnak commented 3 years ago

Discussed, agreed to leave it as is

vkrajnak commented 3 years ago

As discussed, due to the different labels for discrete, continuous and stochastic systems, it is easier to drop all and leave the user to use the plot handle for customisation

vkrajnak commented 3 years ago

49