options.multiple appears to incorrectly set fileLimit to 1

[keithj2780]

I'd expect leaving options.multiple as the default & setting options.fileLimit to anything > 1 to allow multiple files to be uploaded.

Is the a ! missing from this code ?

export function processFiles(files: FileWithPath[], options: FileDropOptions): Files {
    let { fileLimit } = options;
    if (options.multiple) {
        fileLimit = 1;
    }

If not, then what options do I set to upload multiple files ?

[chanced]

Ah, yea. I definitely missed a ! there. My apologizes.

[chanced]

That should be fixed. I also added harnesses to properly test this. Hopefully I'll have decent coverage early next week.

I spot checked the fix and pushed a new version (0.0.10).

if (options.multiple != undefined && !options.multiple) {
    fileLimit = 1;
}

[keithj2780]

Many thanks for the fast fix.  0.0.10 is working for me now :)

Cheers Keith

On 5/09/2021 2:50 pm, Chance wrote:

That should be fixed. I also added harnesses to properly test this. Hopefully I'll have decent coverage early next week.

I spot checked the fix and pushed a new version (0.0.10).

if (options.multiple != undefined && !options.multiple) { fileLimit = 1; }

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chanced/filedrop-svelte/issues/1#issuecomment-913085985, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC5ASWBEWC546VH5HMPD653UALZIZANCNFSM5DN5TQTQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.