Open chanced opened 2 weeks ago
Attention: Patch coverage is 82.29167%
with 34 lines
in your changes missing coverage. Please review.
Project coverage is 97.1%. Comparing base (
c694765
) to head (45c4fde
).
Files with missing lines | Patch % | Lines |
---|---|---|
src/resolve.rs | 76.6% | 32 Missing :warning: |
src/assign.rs | 96.3% | 2 Missing :warning: |
Solves #90
assign::AssignError
toassign::Error
assign::AssignError
forassign::Error
resolve::ResolveError
toresolve::Error
resolve::ResolveError
forresolve::Error
position
(token index) to variants ofassign::Error
&resolve::Error
I'm not certain
position
is the right term to use here. Instinctively, I'd reach forindex
oridx
but that may lead to confusion overIndex
related errors, especially those specific to parsing anIndex
.This makes
AssignError
andResolveError
more idiomatic by reducing redundancy in renaming toError
. I'm not sure whether or not we should#[deprecate]
the type aliasesAssignError
andResolveError
.I regret making both errors' variants embedded structs rather than just rolling structs for each variant. I thought long and hard about splitting them out as structs but that's going to introduce far more breaking changes. While this is definitely breaking, I'm hoping that
..
or simply adding aposition
to{ }
on matches won't be that much of a hassle.