chancejs / chancejs

Chance - Random generator helper for JavaScript
http://chancejs.com
MIT License
6.45k stars 456 forks source link

Improve consistency of formatting #545

Open PhiLhoSoft opened 2 years ago

PhiLhoSoft commented 2 years ago

Like no spaces inside soft braces (seemed the initial/base/majority), except in doc, where the reverse was the majority. Fixing indentation (very long lists less indented for saving space). Uniformize error messages. Spaces around operators. Else on previous closing soft brace. Etc. Didn't try to uniformize quotes, though. Manual fixes, some stuff might have been missed.

PhiLhoSoft commented 2 years ago

I wanted a sane base to add improvements, like fixing and adding French lists, adding some functions, adding missing docs, etc.

victorquinn commented 2 years ago

I am so sorry this has sat here so long without a review! I love it, just haven't had time to review it due to the breadth of the changes but they are all really great, love consistency!

Many of the items we should add as rules to the linter so they are strongly enforced moving forward.

Anyway, will review as soon as I am able, apologies again for letting this sit for so long, this is amazing :heart: