search

chancezeus / angular-laravel-echo

A Angular service for working with laravel-echo
MIT License
18 stars 21 forks source link

EchoService.echo now becomes public, because right now there is no wa… #4

Closed qialex closed 6 years ago

qialex commented 6 years ago

EchoService.echo now becomes public, because right now there is no way to check weather if socket is connected or not"

chancezeus commented 6 years ago

I modified the service to include a getter for the EchoService.echo instance instead of just making it public (since "setting" it will break the service). I also added a "connected" getter which should work for all connector types (based on docs), but I have not yet had time to test either, so please update to the latest published version(s) to check them and let me know

qialex commented 6 years ago

chancezeus, thank you for modification. I agree that making EchoService.echo public is not a good idea. Let's close this pr. I added new PR https://github.com/chancezeus/angular-laravel-echo/pull/7 where I suggest to add observer for connection state