search

chandachewe10 / loan-management-system

Loan Management Software
80 stars 68 forks source link

Bug Fix on Creating Borrower Page #29

Closed bereank closed 2 weeks ago

bereank commented 3 weeks ago

Changing Added By Input in Creating Borrower form from TextInput to Select Input since TextInput doest not support relationship, this will fix Resolves #27

chandachewe10 commented 3 weeks ago

Thanks am sure this will work. Just some changes which I want to make,I came to realize that this functionality which I added will allow the person adding the borrower to add another person as the one who added the borrower.

For example if am the loan officer and am adding a borrower when I reach 'Added by' I can easily choose you (assuming you are in the system) under the drop down as a person who added that borrower. Please share your thoughts on that probably I added that in the wrong place in the first place. What about this. In the resources I can add this: Forms\Components\TextInput::make('added_by') ->hidden(),

And the create Borrower page I can also include this: $data['added_by'] = auth()->user()->id        return $data;

So that the person adding the borrower cannot manipulate the person who added the borrower. Let me know your thoughts and if a PR can be made

bereank commented 2 weeks ago

I believe that will work, if the idea is to capture Creator of the resource, its better be added Create Borrow page as mention, Can i include this on this PR? @chandachewe10

chandachewe10 commented 2 weeks ago

@bereank yes sure will appreciate

bereank commented 2 weeks ago

@chandachewe10 I have updated on the PR, Review on this PR

chandachewe10 commented 2 weeks ago

@bereank thanks