search

chandra-mta / Ocat_Flask_App

USINT Ocat written in the Python Flask Web Framework
0 stars 0 forks source link

ACIS sign off required for target name changes #27

Closed william-aaron-CFA closed 1 week ago

william-aaron-CFA commented 7 months ago

In the Target Parameter Status web page, revisions on ObsID 28149, 28558-28567 were listed as target names changes and required ACIS SI mode sign offs. However, this is not handled by ACIS team.

william-aaron-CFA commented 1 week ago

This specific line in the updater for our file records lists that it is a requirement for the ACIS SI mode to be rechecked in the event of a target name change. https://github.com/chandra-mta/Ocat_Flask_App/blob/9cec1c4f35b3485db72bcde3d0728b6aadb45275/cus_app/ocatdatapage/update_data_record_file.py#L469-L478

Not only that, but in the event of a target name change, there exists a warning that Mission Planning will be notified of this change. https://github.com/chandra-mta/Ocat_Flask_App/blob/9cec1c4f35b3485db72bcde3d0728b6aadb45275/cus_app/ocatdatapage/check_value_range.py#L266-L281

Yet no notification email exists for this specific targname parameter change event.

william-aaron-CFA commented 1 week ago

This issue as referenced is addressed in PR #53. The additionally mentioned lack of a target name change notification email to mission planning will be addressed in a separate issue #54