search

chandra-mta / space_weather

All space weather monitoring. ACE, GOES, KP.
1 stars 0 forks source link

disable ACE scaled alerts per radiation working group #2

Open bspitzbart opened 11 years ago

swolk commented 11 years ago

do I need to do this action, or can you, once Tom is happy?

It looks fine to me.

The other change, the 1 hour wait on SCS 107 re-arm, is trickier

On Thu, Jun 6, 2013 at 10:30 AM, bspitzbart notifications@github.comwrote:

You can merge this Pull Request by running

git pull https://github.com/mta/space_weather disable_scaled

Or view, comment on, or merge it at:

https://github.com/mta/space_weather/pull/2 Commit Summary

  • disable ACE scaled alerts per radiation working group

File Changes

  • M aceviolation_protonsP6.cshhttps://github.com/mta/space_weather/pull/2/files#diff-0(11)

Patch Links:

-Scott

swolk@cfa.harvard.edu

Chandra X-Ray Center Harvard-Smithsonian Center for Astrophysics | 617-496-7766 60 Garden St. MS-70 | 617-721-4360 (cell phone) Cambridge, MA 02138 | 617-495-7356 (fax) http://hea-www.harvard.edu/~swolk

taldcroft commented 11 years ago

@bspitzbart - at this point I would suggest that you essentially start over by going back to master and making a new branch with a somewhat different name. The required code patch is really simple, just delete the two code blocks that currently test the scaled p5 and p6 rates. Take out the entire code blocks and leave only emptiness, but put in a good commit message, that might look something like:

Remove code that issues scaled p5 and p6 alerts

Two code blocks within process_ace.nawk were responsible for testing the
scaled p5 -> p3 and p6 -> p3 rates.  If these exceeded the thresholds then
another script was called to actually send the alerts.  Based on a decision
by the radiation working group these scaled alerts are no longer desired.

Note the very short (< 70 characters) commit title, followed by a blank line, followed by a detailed description. The detailed description isn't always required, but in this case would be quite useful. Following this format is useful for github because the messages show up nicely formatted.

That's all that will be needed and this can go through.

taldcroft commented 11 years ago

BTW, when you format the commit as above you should see the magic when you issue the pull request, which is that it is all filled in nicely.