chandu0101 / scalajs-react-components

Reusable scalajs-react components
http://chandu0101.github.io/sjrc/
Apache License 2.0
163 stars 65 forks source link

Add support for scalajs-react 1.2.0 #99

Open bijancn opened 6 years ago

bijancn commented 6 years ago

When I try to compile, I get linker errors like this

[error] Referring to non-existent method japgolly.scalajs.react.component.Js$.apply(scala.scalajs.js.Any,japgolly.scalajs.react.CtorType$Summoner)japgolly.scalajs.react.component.JsBaseComponentTemplate$ComponentWithRoot
[error]   called from chandu0101.scalajs.react.components.elementalui.Table.apply(scala.collection.Seq)japgolly.scalajs.react.component.Js$UnmountedWithRoot

by using

import chandu0101.scalajs.react.components.elementalui._
        Table()(),

I am not sure why apply methods of components don't work anymore. Here are the release notes https://github.com/japgolly/scalajs-react/blob/97de7d9083f2e793c456866f60d42dd3cd483e21/doc/changelog/1.2.0.md

rleibman commented 6 years ago

Have you tried compiling it for 1.2.0? I can work on this. I think the first thing I find is that ReactElement was renamed to React.Element