changcheng / wro4j

Automatically exported from code.google.com/p/wro4j
0 stars 0 forks source link

csslint not working via maven since 1.4.2 #366

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
csslint not working via maven since 1.4.2. I am violating 2 rules in my CSS

pom.xml:

            <plugin>
                <groupId>ro.isdc.wro4j</groupId>
                <artifactId>wro4j-maven-plugin</artifactId>
                <version>1.4.3</version>
                <executions>
                    <execution>
                        <goals>
                            <goal>csslint</goal>
                        </goals>
                    </execution>
                </executions>
                <configuration>
                  <contextFolder>${warOutputLocation}</contextFolder>
                  <options>ids,adjoining-classes,box-model,box-sizing,compatible-vendor-prefixes,display-property-grouping,duplicate-background-images,duplicate-properties,empty-rules,errors,fallback-colors,floats,font-faces,font-sizes,gradients,import,important,known-properties,outline-none,overqualified-elements,qualified-headings,regex-selectors,rules-count,shorthand,text-indent,unique-headings,universal-selector,unqualified-attributes,vendor-prefix,zero-units</options>
                </configuration>
            </plugin>

1.4.1:

[INFO] --- wro4j-maven-plugin:1.4.1:csslint (default) @ personalwebsite ---
[INFO] Executing the mojo: 
[INFO] Wro4j Model path: C:\dev\personalwebsite\src\main\webapp\WEB-INF\wro.xml
[INFO] targetGroups: null
[INFO] minimize: true
[INFO] ignoreMissingResources: true
[INFO] wroManagerFactory: null
[INFO] options: 
ids,adjoining-classes,box-model,box-sizing,compatible-vendor-prefixes,display-pr
operty-grouping,duplicate-background-images,duplicate-properties,empty-rules,err
ors,fallback-colors,floats,font-faces,font-sizes,gradients,import,important,know
n-properties,outline-none,overqualified-elements,qualified-headings,regex-select
ors,rules-count,shorthand,text-indent,unique-headings,universal-selector,unquali
fied-attributes,vendor-prefix,zero-units
[INFO] failNever: false
[INFO] wroManagerFactory class: 
ro.isdc.wro.extensions.manager.standalone.ExtensionsStandaloneManagerFactory
0    INFO SmartWroModelFactory - Using XmlModelFactory for model creation..
2    INFO SmartWroModelFactory -    loading autodetected wro file: 
C:\dev\personalwebsite\src\main\webapp\WEB-INF\wro.xml
[INFO] processing group: all.css
[INFO] ManagerFactory: ro.isdc.wro.manager.WroManager@945b95[
  modelFactory=ro.isdc.wro.model.factory.ModelTransformerFactory@8a6fc
  groupExtractor=ro.isdc.wro.manager.factory.standalone.DefaultStandaloneContextAwareManagerFactory$1@b1684
  hashBuilder=ro.isdc.wro.model.resource.util.SHA1HashBuilder@1f35e30
  cacheStrategy=ro.isdc.wro.cache.impl.LruMemoryCacheStrategy@accd65
  cacheChangeCallback=<null>
  scheduler=<null>
  processorsFactory=ro.isdc.wro.model.group.processor.InjectorProcessorsFactoryDecorator@e0d16b
  uriLocatorFactory=ro.isdc.wro.model.resource.locator.factory.InjectorUriLocatorFactoryDecorator@1d4f355
  namingStrategy=ro.isdc.wro.model.resource.util.NoOpNamingStrategy@1b38cdc
  groupsProcessor=ro.isdc.wro.model.group.processor.GroupsProcessor@e4d0cd
]
398  INFO SmartWroModelFactory - Using XmlModelFactory for model creation..
398  INFO SmartWroModelFactory -    loading autodetected wro file: 
C:\dev\personalwebsite\src\main\webapp\WEB-INF\wro.xml
[INFO] processing resource: /style/main.css
[ERROR] 2 errors found while processing resource: /style/main.css Errors are: 
[ro.isdc.wro.extensions.processor.support.csslint.CssLintError@1e965e9[
  type=warning
  message=Values of 0 shouldn't have units specified.
  rule=ro.isdc.wro.extensions.processor.support.csslint.CssRule@21b97e[
  id=zero-units
  name=Zero Units
  desc=You don't need to specify units when a value is 0.
  browsers=All
]
  line=5
  col=11
  evidence=  margin: 0px;
], ro.isdc.wro.extensions.processor.support.csslint.CssLintError@190c99[
  type=warning
  message=Don't use IDs in selectors.
  rule=ro.isdc.wro.extensions.processor.support.csslint.CssRule@8a1f38[
  id=ids
  name=IDs
  desc=Selectors should not contain IDs.
  browsers=All
]
  line=8
  col=1
  evidence=#main {
]]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

1.4.3:

[INFO] --- wro4j-maven-plugin:1.4.3:csslint (default) @ personalwebsite ---
[INFO] Executing the mojo: 
[INFO] Wro4j Model path: C:\dev\personalwebsite\src\main\webapp\WEB-INF\wro.xml
[INFO] targetGroups: null
[INFO] minimize: true
[INFO] ignoreMissingResources: true
[INFO] wroManagerFactory: null
[INFO] extraConfig: 
C:\dev\personalwebsite\src\main\webapp\WEB-INF\wro.properties
[INFO] options: null
[INFO] failNever: false
[INFO] wroManagerFactory class: 
ro.isdc.wro.extensions.manager.standalone.ExtensionsStandaloneManagerFactory
[INFO] processing group: all.css
[INFO] ManagerFactory: ro.isdc.wro.manager.WroManager@1353154[
  modelFactory=ro.isdc.wro.manager.WroManager$3@1398cac
  groupExtractor=ro.isdc.wro.manager.factory.standalone.DefaultStandaloneContextAwareManagerFactory$1@1429cf1
  hashBuilder=ro.isdc.wro.model.resource.util.SHA1HashBuilder@4d93e3
  cacheStrategy=ro.isdc.wro.cache.impl.LruMemoryCacheStrategy@128215d
  cacheChangeListener=<null>
  cacheSchedulerHelper=ro.isdc.wro.util.SchedulerHelper@1a697a1
  modelSchedulerHelper=ro.isdc.wro.util.SchedulerHelper@2cd728
  processorsFactory=ro.isdc.wro.model.resource.processor.factory.SimpleProcessorsFactory@1e1a0ee[
  preProcessors=[ro.isdc.wro.maven.plugin.CssLintMojo$1@1e5cf0]
  postProcessors=[]
]
  uriLocatorFactory=ro.isdc.wro.model.resource.locator.factory.SimpleUriLocatorFactory@167c6fd
  namingStrategy=ro.isdc.wro.model.resource.util.NoOpNamingStrategy@39452f
  callbackRegistry=ro.isdc.wro.manager.callback.LifecycleCallbackRegistry@1ed13da
  groupsProcessor=ro.isdc.wro.model.group.processor.GroupsProcessor@1b25a82
]
[INFO] processing resource: /style/main.css
[INFO] Success processing group: all.css
[INFO] processing group: all.js
[INFO] ManagerFactory: ro.isdc.wro.manager.WroManager@1353154[
  modelFactory=ro.isdc.wro.manager.WroManager$3@1398cac
  groupExtractor=ro.isdc.wro.manager.factory.standalone.DefaultStandaloneContextAwareManagerFactory$1@1429cf1
  hashBuilder=ro.isdc.wro.model.resource.util.SHA1HashBuilder@4d93e3
  cacheStrategy=ro.isdc.wro.cache.impl.LruMemoryCacheStrategy@128215d
  cacheChangeListener=<null>
  cacheSchedulerHelper=ro.isdc.wro.util.SchedulerHelper@1a697a1
  modelSchedulerHelper=ro.isdc.wro.util.SchedulerHelper@2cd728
  processorsFactory=ro.isdc.wro.model.resource.processor.factory.SimpleProcessorsFactory@1e1a0ee[
  preProcessors=[ro.isdc.wro.maven.plugin.CssLintMojo$1@1e5cf0]
  postProcessors=[]
]
  uriLocatorFactory=ro.isdc.wro.model.resource.locator.factory.SimpleUriLocatorFactory@167c6fd
  namingStrategy=ro.isdc.wro.model.resource.util.NoOpNamingStrategy@39452f
  callbackRegistry=ro.isdc.wro.manager.callback.LifecycleCallbackRegistry@1ed13da
  groupsProcessor=ro.isdc.wro.model.group.processor.GroupsProcessor@1b25a82
]
[INFO] Success processing group: all.js

Original issue reported on code.google.com by alistair...@gmail.com on 1 Feb 2012 at 1:50

GoogleCodeExporter commented 9 years ago

Original comment by alex.obj...@gmail.com on 1 Feb 2012 at 8:04

GoogleCodeExporter commented 9 years ago
Fixed in branch 1.4.x. Apparently the options were not built properly and this 
did affect the CssLintProcessor (not only csslint maven goal).

Original comment by alex.obj...@gmail.com on 3 Feb 2012 at 11:03