search

changchiyou / wildrift-gold-efficiency

Gold efficiency (Wild Rift)
https://changchiyou.github.io/wildrift-gold-efficiency/
MIT License
1 stars 1 forks source link

refactor: extract `RSS` page-link from menu and place it adjacent to the menu #12

Closed changchiyou closed 3 months ago

changchiyou commented 3 months ago
Now(1) Now(2) Expect
changchiyou commented 3 months ago

finished with ~ 27b9f862e7b28b0a9e2ab49fa8eb612477a4a7f7 ：

web phone

However, there are two small issues:

  1. ( solved in 27b9f862e7b28b0a9e2ab49fa8eb612477a4a7f7 ) the RSS icon is currently fetched from <script src="https://kit.fontawesome.com/4078098091.js" crossorigin="anonymous"></script>, which requires additional loading time.

  2. (solved in https://github.com/changchiyou/wildrift-gold-efficiency/commit/2ecb283e305a913bd81fe586260566b6a8aafc65 ) the menu cannot cover the RSS icon when expanded.

    before after