Open iamyoki opened 2 years ago
I have the same issue. Neither GitHub Release nor git tag is created.
https://github.com/jjangga0214/haetae/runs/7351224812?check_suite_focus=true
This is my public repo's workflow. As you can confirm, it's published but GitHub Releases weren't created. No git tag is created as well.
@jjangga0214 Your problem is the same as mine. But publish works for me. You should use changeset publish
instead of pnpm publish
.
@iamyoki Thanks for the reply.
I think you misunderstood what I meant.
it's published but GitHub Releases weren't created.
What I meant was that the packages were successfully published to npm. (even with pnpm publish -r
)
But GitHub Releases were not created.
@jjangga0214 pnpm publish can publish to npm, but not create github release, that's because you didn't use changesets cli to publish and pnpm doesn't have that ability as changesets.
@iamyoki
I see. Thanks.
I also of course knew that pnpm publish
does not care about changeset.
However, I expected this action to create GitHub Releases under the hood.
As I thought this is the feature of the action, I saw this behavior was a bug.
It seems like I misunderstood. Has this action actually never provided this feature? Should this concern be separated as another issue, as a feature request?
😆 I think our demands are the same.
@mitchellhamilton @Andarist @zkochan
Hi, thankful, dear maintainers! May I ping you?
I feel GitHub Release should be automatically posted even when a user configures with.publish
without changeset publish
.
For example, as you can see in my repo, I stick with with.publish: pnpm publish -r
because of several benefits pnpm offers, like speed and safe topological order.
I really want changesets/action
to post GitHub Release in this case as well.
I believe the action can do that under the hood, without forcing a user to only explicitly depend on changeset publish
.
also facing that no git tag nor release were created with action - do i need to adaped the action somehow?
My
release.yml
like this:Problem
Expected