changesets / action

661 stars 231 forks source link

Major version bump where minor is set #358

Open wallwhite opened 5 months ago

wallwhite commented 5 months ago

Recently, we faced the issue with versioning for the second time and decided to create this issue. I've tried to find some solutions or answers why it happens but didn't found anything helpful.

In our project we have a bunch of fixed packages to have consistency when something has changed. Here is how our config looks:

{
  "$schema": "https://unpkg.com/@changesets/config@3.0.0/schema.json",
  "changelog": "@changesets/cli/changelog",
  "commit": false,
  "fixed": [[
    "@organization/anchor",
    "@organization/badge",
    "@organization/button",
    "@organization/container",
    "@organization/divider",
    "@organization/form",
    "@organization/heading",
    "@organization/hint",
    "@organization/icon-container",
    "@organization/icons",
    "@organization/inputs",
    "@organization/stack",
    "@organization/tag",
    "@organization/text",
    "@organization/theme",
    "@organization/react-core"
  ]],
  "linked": [],
  "access": "restricted",
  "baseBranch": "develop",
  "updateInternalDependencies": "patch",
  "ignore": [
    "@organization/react-storybook"
  ]
}

And here is the latest generated changeset md file:

---
"@organization/anchor": minor
"@organization/badge": minor
"@organization/button": minor
"@organization/container": minor
"@organization/divider": minor
"@organization/form": minor
"@organization/heading": minor
"@organization/hint": minor
"@organization/icon-container": minor
"@organization/icons": minor
"@organization/inputs": minor
"@organization/stack": minor
"@organization/tag": minor
"@organization/text": minor
"@organization/react-core": minor
"@organization/theme": minor
"@organization/vite-config-package": minor
"@organization/eslint-config": minor
"@organization/eslint-config-legacy": minor
"@organization/stylelint-config": minor
"@organization/ts-config": minor
---

Release note...

From the first sight, everything looks nice.

The previous versions of our packages was next:

When the "github action" had been completed we've seen that most of our packages' versions was bumped to next major version instead of minor. The major version was applied to the all components' packages but not for system configs. Looks like the issue is related to fixed version functionality.

vicary commented 1 month ago

I think we are experiencing a similar issue at https://github.com/changesets/action/issues/381, our patch changes are released as major changes.