search

changesets / action

682 stars 242 forks source link

Move dependency updates to bottom unless major #55

Open gautamsi opened 4 years ago

gautamsi commented 4 years ago

For example see this - https://github.com/keystonejs/keystone/pull/3605

there are tons of @renovate changes which fills the changelog with lot of dependency updates, this also clutters the view and not possible to see relevant changes

May I suggest that the changeset is created as such it will move all dependency update to bottom of the post. It would also be nice to add this as Table in monorepo packages and changes in dependency.

something like this (package version not actual)

package Dependency change type contributor
@keystonejs/keystone@20.2.0 express@5 major @renovate
@keystonejs/app-admin-ui@11.3.2 react@16.21 minor @renovate
@keystonejs/logger@8.0.0 winston@1.32. patch @renovate
Andarist commented 4 years ago

Those are per package information - personally I would find it harder to scan as a user if I would have to jump between entries for a particular package and the bottom of the PR message 🤔

gautamsi commented 4 years ago

It makes scanning more difficult if there is important breaking changes in changeset but all those bot created pull requests have 1 package update and it clutter the post.

Andarist commented 4 years ago

Shouldn't scan for breaking changes boil down to cmd+f: "major"?

gautamsi commented 4 years ago

Search for markdown text is even better in GitHub with this logic.

Point is that when packages are upgraded by hand over few weeks/release it is not that cluttered. With the use of bots the changeset is being cluttered and defeats the purpose of having a changeset pr.

I am not insisting to the format I proposed. This is one possibility to de-clutter the bots. Propose a better approach to de-clutter bots. All I need to know if there is better changes to follow other than the dependency update especially with the bots.