search

changesets / bot

https://github.com/apps/changeset-bot
58 stars 20 forks source link

Do not comment on some PRs, based on private packages or changed path? #39

Open FredKSchott opened 3 years ago

FredKSchott commented 3 years ago

Hello! We're using changeset for Astro and are loving it so far. However, we have some workspace "packages" that aren't really packages. The docs site, the www homepage, and some example directories are all included in our workspace (with "private": true).

Is it possible to configure the bot to not comment on those PRs? It is distracting for our users who think they need a changeset added, when in reality we do not usually bump these packages.

Alternatively, is there any condition where the bot doesn't trigger on a new PR that we could leverage? Happy if there is some workaround that we could use.

Example PR: https://github.com/snowpackjs/astro/pull/1042

cristobal commented 2 years ago

I guess this is kind of related with #11. From what i see the changeset bot works pretty well in the two following cases:

  1. A non monorepo single package
  2. A monorepo where all packages are published

But it does not work well with the case where one has a monorepo where only some of the packages under the monorepo are actually published to npm and intended to be under controll of the changesets bot.

My thought here is that some architecture changes to how the bot should behave must be done to accomplish this feature.

timbonicus commented 2 years ago

+1 to this feature, we have a monorepo where packages are marked private while in-development, until they are ready to be published. Enabling the changesets bot in this repo is noisy/actively misleading for authors developing those packages, but it would be super nice to have enabled for packages that are actually published.

This seems in line with changesets in general, since it does not attempt to publish private packages.