search

changesets / bot

https://github.com/apps/changeset-bot
58 stars 20 forks source link

fix: malformed addChangesetUrl #76

Closed russell-dot-js closed 1 year ago

russell-dot-js commented 1 year ago

The URL generated by the bot is malformed and when trying to commit via github UI you get an error that the file cannot be written. This PR fixes the url

Before: https://github.com/path/to/repo/new/branch?filename=.changeset/name.md&value=...

After: https://github.com/path/to/repo/new/branch/.changeset?filename=name.md&value=...

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changesets-bot ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2023 8:32pm
russell-dot-js commented 1 year ago

~~I was assuming the bot would run on this PR and I could use it to add a changeset :D I'll add one later when at computer.~~ nevermind, it looks like this repo doesn't use changesets 😆

russell-dot-js commented 1 year ago

I'm going to go ahead and say this was a temporary bug @ github they've since patched. When I put up this PR, the "before" links did not work and the "after" links did work. Now, the "before" links work and the "after" links do not work. Don't mind me 🫠