Make the success message shorter

changesets / bot

https://github.com/apps/changeset-bot

56 stars 20 forks source link

Open eoghanmurray opened 10 months ago

eoghanmurray commented 10 months ago

Make the success message shorter than the failure message and tweak the visuals to better distinguish the two.

Ref #79

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
changesets-bot	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 8, 2023 3:51pm

eoghanmurray commented 10 months ago

in the absent version, does the getReleasePlanMessage(releasePlan) always return the 'when changesets are added to this PR...' message? If so, then that could be inlined and made visually distinctive (rather than both messages having a bit that is expandable)
I looked at the git log but couldn't really see the reason for including the ${commitSha} in either the absent or the approve message; removing from only the approve message for brevity

eoghanmurray commented 10 months ago

What current iteration of ths PR looks like: