search

changeweb / Unifiedtransform

A school management Software
https://changeweb.github.io/Unifiedtransform/
GNU General Public License v3.0
2.8k stars 1.23k forks source link

propose better docker setup #271

Closed handhikadj closed 3 years ago

handhikadj commented 3 years ago

please take a look at this proposal especially on readme at: https://github.com/handhikadj/Unifiedtransform/blob/38ef46dc145a0ca272118730416e119493e98fa2/readme.md#using-docker-container

changeweb commented 3 years ago

@handhikadj please create a new pull request with only updated/new files. Readme.md is well-done.

This update will keep the project up to date! Have you tested this Docker setup in your machine?

handhikadj commented 3 years ago

of course I tested it out on my mac on docker for mac and it runs flawlessly I updated readme.md so that people know how to use it. I only update stuff regarding what I've done on the proposal

changeweb commented 3 years ago

I know but the other unchanged files were also added in the Pull Request you made. I am suggesting to exclude those files in your new Pull Request.

handhikadj commented 3 years ago

it won't affect anything actually. they're only permission thingy.

changeweb commented 3 years ago

@handhikadj I am sorry for not reviewing your Pull Request early and for not properly thanking you for your contribution. I was a bit busy with my other works.

This is an important upgrade for those who want to use Docker. Good work 👍

handhikadj commented 3 years ago

never mind, bud. I use this docker setup in my day-to-day sysadmin even in production, regardless the system operation i'm running on