search

changeweb / Unifiedtransform

A school management Software
https://changeweb.github.io/Unifiedtransform/
GNU General Public License v3.0
2.78k stars 1.22k forks source link

refactor: clean unused imports in controllers and extend from control… #376

Open lavy opened 1 year ago

lavy commented 1 year ago

Refactor for controllers:

I remove the unused imports on controllers and make Controller as the base class with SchoolSession, on this way we could get sessions from controllers

lavy commented 1 year ago

@changeweb can you merge it? I want to collaborate more with the next features, we could try to implement improvements

changeweb commented 1 year ago

@changeweb can you merge it? I want to collaborate more with the next features, we could try to implement improvements

@lavy , Great to hear that you are eager to collaborate. I will get free time on 20th Jan and I will review these pull requests. Hope you understand.

I would appreciate if you could add tests for any PRs. Thanks for the PRs BTW.

lavy commented 1 year ago

Hi @changeweb in the next PRs i will add tests, in this case i didn't change so much, but i want to try to help in organize first and after that introduce some tests

changeweb commented 1 year ago

@lavy please address the review.

lavy commented 1 year ago

Do you review it on pair? i have no time in this moment.

changeweb commented 1 year ago

Do you review it on pair? i have no time in this moment.

I reviewed it. Please check now.