search

changlan / kytan

kytan: High Performance Peer-to-Peer VPN in Rust
Apache License 2.0
490 stars 60 forks source link

change args parser and add a set_dns function #32

Closed oowl closed 5 years ago

oowl commented 5 years ago
  1. use rust-2018 version grammar
  2. change getopts to the more modern clap
  3. add dns information to Struct Response, then we can specify a dns server to client.

Then I will add KCP support to kytan 😁

codecov[bot] commented 5 years ago

Codecov Report

Merging #32 into master will decrease coverage by 3.26%. The diff coverage is 41.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   67.13%   63.87%   -3.27%     
==========================================
  Files           5        6       +1     
  Lines         493      562      +69     
==========================================
+ Hits          331      359      +28     
- Misses        162      203      +41
Impacted Files Coverage Δ
src/packet.rs 98.03% <ø> (ø) :arrow_up:
src/main.rs 5% <0%> (+5%) :arrow_up:
src/cli.rs 0% <0%> (ø)
src/device.rs 82.14% <100%> (ø) :arrow_up:
src/network.rs 67.56% <100%> (+0.38%) :arrow_up:
src/utils.rs 73.72% <93.33%> (+5.25%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f769b9...f5f43b6. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #32 into master will decrease coverage by 3.26%. The diff coverage is 41.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   67.13%   63.87%   -3.27%     
==========================================
  Files           5        6       +1     
  Lines         493      562      +69     
==========================================
+ Hits          331      359      +28     
- Misses        162      203      +41
Impacted Files Coverage Δ
src/packet.rs 98.03% <ø> (ø) :arrow_up:
src/main.rs 5% <0%> (+5%) :arrow_up:
src/cli.rs 0% <0%> (ø)
src/device.rs 82.14% <100%> (ø) :arrow_up:
src/network.rs 67.56% <100%> (+0.38%) :arrow_up:
src/utils.rs 73.72% <93.33%> (+5.25%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f769b9...eeb8bdd. Read the comment docs.

changlan commented 5 years ago

Thanks! This PR has been merged.

oowl commented 5 years ago

Can you try to solve my issues?