changliao1025 / hexwatershed

The C++ backend of the HexWatershed a mesh independent flow direction model for hydrologic models
Other
3 stars 0 forks source link

Remove unused variables, fix comparisons #5

Closed r-barnes closed 11 months ago

r-barnes commented 2 years ago

There are many unused variables; this makes the code more difficult to read.

There are also many comparison between signed and unsigned variables; such comparisons are error-prone.

This PR removes most of the unused variables and fixes said comparisons along with other code cleaning.

changliao1025 commented 1 year ago

@r-barnes Indeed, some are either unused or reserved for future development. I will take a look and clean up.