search

changwoonchoi / IBL-NeRF

Official implementation of IBL-NeRF: Image-Based Lighting Formulation of Neural Radiance Fields (Computer Graphics Forum, Pacific Graphics 2023)
https://changwoon.info/publications/IBL-NeRF
MIT License
40 stars 4 forks source link

Edit Failure Question #10

Closed yunchao-ding closed 6 months ago

yunchao-ding commented 1 year ago

Hi, Why did I add a mask image to be edited in the test, but the generated image did not achieve the editing effect? The generated image only had an obvious mask image in the results "n_dot_v_000. png", "reflected_coarse_radiance_x_000. png", "reflected_radiance_000. png", "target_normal_map_000. png", but there was no editing success or trace of editing in "radiance_000. png", "rgb_000. png". The purpose of my preparation for editing was to roughen up the thick wall of the teapot in the kitchen scene to make it non reflective, but it seems to have failed.

Pomelo-king commented 1 year ago

Did you fail to edit the mask map because you did not upload it correctly?

Pomelo-king commented 1 year ago

However, I have a question about how to modify the roughness to achieve the editing effect in the paper?

xcandxc commented 1 year ago

When I was editing, I only managed to achieve changes in reflectance intensity in the results, but I didn't achieve any changes in roughness, nor was I able to achieve the realistic effect mentioned in the paper, especially in editing the lampshade in the kitchen scene.

Pomelo-king commented 1 year ago

I can retrieve the reflectance and roughness results, but I still couldn't reproduce the perfect results as shown in the paper.

Pomelo-king commented 1 year ago

Hi, Why did I add a mask image to be edited in the test, but the generated image did not achieve the editing effect? The generated image only had an obvious mask image in the results "n_dot_v_000. png", "reflected_coarse_radiance_x_000. png", "reflected_radiance_000. png", "target_normal_map_000. png", but there was no editing success or trace of editing in "radiance_000. png", "rgb_000. png". The purpose of my preparation for editing was to roughen up the thick wall of the teapot in the kitchen scene to make it non reflective, but it seems to have failed. Is it possible that your image settings are incorrect? I also encountered the same issue before, but I eventually resolved it.

yunchao-ding commented 1 year ago

Hi, How did you modify the albedo to white, red, and green in your paper? At the same time, after modifying the roughness, the generated image looks very realistic. How is it set?

yunchao-ding commented 1 year ago

No matter how the albedo and roughness parameters are set, the results do not change. Why is this? Set the following parameters: editing target albedo list = [0.1] editing target roughness list = [1]

yunchao-ding commented 1 year ago

rgb_000 Hi,I still haven't been able to solve this problem, no matter what I do, I can't change the albedo and roughness of the target area, only get an image like this.Hope to get your advice!

changwoonchoi commented 6 months ago

Sorry for very late reply..

As I mentioned my reply in #13 , we did not provide the example files for editing but you can freely edit whatever you want. To @yunchao-ding, as @Pomelo-king is able to edit the scene, I'll close the issue.

Basically, to edit scenes or insert the object, all you need it the final pixel-wise values what you want to override!