search

chanhx / crabviz

🦀 A LSP-based interative call graph generator
Apache License 2.0
674 stars 22 forks source link

Fix Windows path bug + ENAMETOOLONG bypass #16

Closed katshup closed 5 months ago

katshup commented 1 year ago

This fixes a pathing issue in Windows that causes edges to not be drawn. The drive letter in paths coming from the selector or directory search is lower case while the drive letter from call hierarchy is upper case. The solution here is to just capitalize the drive letter from the selector / directory search.

Additionally a bypass to the ENAMETOOLONG issue for very large projects by not searching if the user only selects files and no directories.

chanhx commented 1 year ago

Thank you for submitting the PR, and sorry for the very late reply. I just tested the extension on Windows, and the edges were showing up in my testing. Maybe you came across the same issue in #9. What’s the language of your project?

chanhx commented 5 months ago

I got this problem when I tested Crabviz on Windows a few days ago, but the last time I tried it on Windows the edges were drawn, don’t have a clue why.

The branch is out-of-date (my bad), so I fixed the bug myself, but thank you all the same.

I'll close this now as the issue has been fixed in de22f929ef270b244fae67b1f03814ac7d08733c.