chanhx / crabviz

🦀 A LSP-based interative call graph generator
Apache License 2.0
674 stars 22 forks source link

feat: multi-select call flows #31

Closed navarrothiago closed 3 months ago

navarrothiago commented 5 months ago

Is there a capability to do multi-select call flows? After generating the graph, the idea is to make some call flows stand out by making them brighter and the others less visible by clicking on just the flows that the user is interested in. It would be great to see this.

chanhx commented 5 months ago

I'm not sure I understand this correctly, do you mean allowing to select multiple edges on the graph?

Have you tried generating a call graph for a selected function? Does that meet your needs?

navarrothiago commented 5 months ago

I'm not sure I understand this correctly, do you mean allowing to select multiple edges on the graph? Yes!

Have you tried generating a call graph for a selected function? Does that meet your needs? I have already tried, but imagine that I want to highlight a specific path (multiple edges + multiple nodes) on that graph ... I am not sure if there is another way to do that.

chanhx commented 5 months ago

I have already tried, but imagine that I want to highlight a specific path (multiple edges + multiple nodes) on that graph ... I am not sure if there is another way to do that.

In that mode, you can highlight all paths (just edges) between the selected node and the origin node. But you want to highlight all the edges and nodes on a specific path and fade the others, right?

There is no way to do that now. I have no idea how to select a path on a graph. Do you have any ideas?

navarrothiago commented 5 months ago

I don't have either. No problem.... Btw, thanks for doing this project. It is awesome.

On Sun, Apr 7, 2024 at 12:47 AM chanhx @.***> wrote:

I have already tried, but imagine that I want to highlight a specific path (multiple edges + multiple nodes) on that graph ... I am not sure if there is another way to do that.

highlight.svg (view on web) https://github.com/chanhx/crabviz/assets/20551552/72bc73d2-0a13-4d10-be78-07655226ee3c

In that mode, you can highlight all paths (just edges) between the selected node and the origin node. But you want to highlight all the edges and nodes on a specific path and fade the others, right?

There is no way to do that now. I have no idea how to select a path on a graph. Do you have any ideas?

— Reply to this email directly, view it on GitHub https://github.com/chanhx/crabviz/issues/31#issuecomment-2041298285, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKFL5AF5HV7YK3NQZFBC75LY4C6T7AVCNFSM6AAAAABFY7HEMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGI4TQMRYGU . You are receiving this because you authored the thread.Message ID: @.***>

-- Thiago Navarro

chanhx commented 5 months ago

Thank you! I'm really glad you like it.

chanhx commented 3 months ago

Closing this issue. Please feel free to reopen this issue if you come up with solutions.